refactoring - Refactor code to remove duplicate code -


i have several classes share common logic. example, class addemployee responsible adding employee api. addlocation responsible adding location of person. classes following :

class addemployee {    public function add()    {       $apiurl = "https://api.abc.com/employees";;          $authparameters = array(             'oauth_consumer_key' => $this->consumer_key,          );          $xml .= <<<eom                 <superfund>                 <abn>$obj->abn</abn>                 <type>regulated</type>                 </superfund>                 eom;          $queryparameters = array(             'xml' => $xml         );          $response = $this->processsrequestandgetresponse('post',$apiurl,$authparameters,$queryparameters,$oauth_secret);          return $response;     } }   class addlocation {    public function add()    {       $apiurl = "https://api.abc.com/locations";;          $authparameters = array(             'oauth_consumer_key' => $this->consumer_key,          );          $xml .= <<<eom                 <location>                 <address1>$obj->abn</address1>                 <city>dhaka</citry>                 </location>                 eom;          $queryparameters = array(             'xml' => $xml         );          $response = $this->processsrequestandgetresponse('post',$apiurl,$authparameters,$queryparameters,$oauth_secret);          return $response;     } }

in above 2 classes, xml part different , others same. in future other new classes added xml different.

my question how can refactor remove duplicate each of classes ?

which design pattern remove duplicate code ?

in case: "nevermind 'patterns' ... do it."

it quite obvious define (protected ...) method takes 2 parameters:   url , xml. spin-off bulk of logic method, change other (public ...) methods call it.

also (and, "imho"):   "at end of day, 'design patterns' meant guidelines." rules-of-thumb, if will. not encounter in real life ever exactly conform "pattern," nor need feel "you must find one" justify you, engineer, decide do.

instead, think very-pragmatically application, work-group, , changes anticipate being necessary in future. try design methods in such way successors, when faced inevitable future change, might not have change "a hundred methods." (instead, foresight, need change few.) use your best judgment, after discussing matter manager , other members of team.


Comments

Post a Comment

Popular posts from this blog

jOOQ update returning clause with Oracle -

according http://www.jooq.org/doc/3.8/manual/sql-building/sql-statements/update-statement/ jooq doesn't support returning clause in update statements databases except firebird , postgres. does know, still correct oracle jooq? according oracle's documentation, oracle db supports returning clase delete, insert, or update statements. incorrect manual you're right - manual wrong , should fixed: https://github.com/jooq/jooq/issues/5470 single row update returning jooq 3.8 added support single row update .. returning statements. internally, uses callablestatement , pl/sql block of form: begin update "my_table" set "my_table"."column" = 'xyz' "my_table"."id" = 1 returning "my_table"."id", "my_table"."column" ?, ?; ? := sql%rowcount; end; the relevant issue is: https://github.com/jooq/jooq/issues/5190 multi row update returning a...
Read more

java - Warning equals/hashCode on @Data annotation lombok with inheritance -

i have entity inherits other. on other hand, i'm using lombok project reduce boilerplate code, put @data annotation. annotation @data inheritance produces next warning: generating equals/hashcode implementation without call superclass, though class not extend java.lang.object. if intentional, add '@equalsandhashcode(callsuper=false)' type. is advisable add annotation @equalsandhashcode (callsuper = true) or @equalsandhashcode (callsuper = false) ? if not added, 1 callsuper=false or callsuper=true ? the default value false . 1 if don't specify , ignore warning. yes, recommended add @equalsandhashcode annotation on @data annotated classes extend else object. cannot tell if need true or false , depends on class hierarchy, , need examined on case-by-case basis. however, project or package, can configure in lombok.config call super methods if not direct subclass of object. lombok.equalsandhashcode.callsuper = call for configuration system ...
Read more

java - BasicPathUsageException: Cannot join to attribute of basic type -

i using java 8 jpa (hibernate 5.2.1). have clause works perfectly, until introduce clause make use foreign key table values too. i getting following error: basicpathusageexception: cannot join attribute of basic type i think problem related fact have join table, , not sure how create join using join table. employee - employee_category - category model (employee.java): @manytomany(cascade = cascadetype.all, fetch=fetchtype.eager) @jointable ( name="employee_category", joincolumns={ @joincolumn(name="emp_id", referencedcolumnname="id") }, inversejoincolumns={ @joincolumn(name="cat_id", referencedcolumnname="id") } ) private set<category> categories; model (category.java): @id private string id; jpa when introduce following code, fails error above (i think problem new piece of code): join<t, category> category = from.join("id"); predicates.add(criteriabuilder.like(category....
Read more