C random matrix with numbers between 0 and 9 -


i'm c newbie , i'm trying make matrix 5x4 numbers between 0 , 9 each number needs there 2 times (i'm trying make memory game). got code think quite mess , not working, question is, how can improve code or how can make matrix in different way? 

#include <stdio.h> #include <math.h> #include <stdlib.h>  #define maxc 4 #define maxl 5    int main(){       int n1=0, n2=0, n3=0, n4=0, n5=0, n6=0, n7=0, n8=0, n9=0, n0=0;     int i=0,j=0,r;     int n[maxl][maxc];     srand(time(null));      while(i<5){         j=0;         while(j<4){              r=(rand()%10);              if(r==0 && n0<2){                 n0++;                 j++;                 n[i][j]=r;                 printf(" %3d ",n[i][j]);             }             if(r==1 && n1<2){                 n1++;                 j++;                 n[i][j]=r;                 printf(" %3d ",n[i][j]);             }             if(r==2 && n2<2){                 n2++;                 j++;                 n[i][j]=r;                 printf(" %3d ",n[i][j]);             }             if(r==3 && n3<2){                 n3++;                 j++;                 n[i][j]=r;                 printf(" %3d ",n[i][j]);             }             if(r==4 && n4<2){                 n4++;                 j++;                 n[i][j]=r;                 printf(" %3d ",n[i][j]);             }             if(r==5 && n5<2){                 n5++;                 j++;                 n[i][j]=r;                 printf(" %3d ",n[i][j]);             }             if(r==6 && n6<2){                 n6++;                 j++;                 n[i][j]=r;                 printf(" %3d ",n[i][j]);             }             if(r==7 && n7<2){                 n7++;                 j++;                 n[i][j]=r;                 printf(" %3d ",n[i][j]);             }             if(r==8 && n8<2){                 n8++;                 j++;                 n[i][j]=r;                 printf(" %3d ",n[i][j]);             }             if(r==9 && n9<2){                 n9++;                 j++;                 n[i][j]=r;                 printf(" %3d ",n[i][j]);             }          }         i++;     }     return 0; }

here little change make program shorter.

i've placed n0, n1, .... array indexed r.

#include <stdio.h> #include <stdlib.h> #include <time.h>  #define maxc 4 #define maxl 5  int main() {     int na[10] = {0};     int n[maxl][maxc], i=0;     srand((unsigned)time(null));      while(i<maxl)     {         int j=0;         while(j<maxc)         {             int r = rand() % 10;             if(na[r]<2)             {                 ++na[r];                 n[i][j] = r;                 printf(" %3d ",n[i][j]);                 ++j;             }         }         ++i;         printf("\n");     }     return 0; }

example output:

   2    6    1    8     4    7    0    2     5    3    7    8     9    1    0    3     5    6    4    9

your code keeps trying random number until have had each number twice. not best approach.

instead initialize matrix 20 numbers @ fix locations , random shuffle of matrix.


Comments

Post a Comment

Popular posts from this blog

jOOQ update returning clause with Oracle -

according http://www.jooq.org/doc/3.8/manual/sql-building/sql-statements/update-statement/ jooq doesn't support returning clause in update statements databases except firebird , postgres. does know, still correct oracle jooq? according oracle's documentation, oracle db supports returning clase delete, insert, or update statements. incorrect manual you're right - manual wrong , should fixed: https://github.com/jooq/jooq/issues/5470 single row update returning jooq 3.8 added support single row update .. returning statements. internally, uses callablestatement , pl/sql block of form: begin update "my_table" set "my_table"."column" = 'xyz' "my_table"."id" = 1 returning "my_table"."id", "my_table"."column" ?, ?; ? := sql%rowcount; end; the relevant issue is: https://github.com/jooq/jooq/issues/5190 multi row update returning a...
Read more

java - Warning equals/hashCode on @Data annotation lombok with inheritance -

i have entity inherits other. on other hand, i'm using lombok project reduce boilerplate code, put @data annotation. annotation @data inheritance produces next warning: generating equals/hashcode implementation without call superclass, though class not extend java.lang.object. if intentional, add '@equalsandhashcode(callsuper=false)' type. is advisable add annotation @equalsandhashcode (callsuper = true) or @equalsandhashcode (callsuper = false) ? if not added, 1 callsuper=false or callsuper=true ? the default value false . 1 if don't specify , ignore warning. yes, recommended add @equalsandhashcode annotation on @data annotated classes extend else object. cannot tell if need true or false , depends on class hierarchy, , need examined on case-by-case basis. however, project or package, can configure in lombok.config call super methods if not direct subclass of object. lombok.equalsandhashcode.callsuper = call for configuration system ...
Read more

java - BasicPathUsageException: Cannot join to attribute of basic type -

i using java 8 jpa (hibernate 5.2.1). have clause works perfectly, until introduce clause make use foreign key table values too. i getting following error: basicpathusageexception: cannot join attribute of basic type i think problem related fact have join table, , not sure how create join using join table. employee - employee_category - category model (employee.java): @manytomany(cascade = cascadetype.all, fetch=fetchtype.eager) @jointable ( name="employee_category", joincolumns={ @joincolumn(name="emp_id", referencedcolumnname="id") }, inversejoincolumns={ @joincolumn(name="cat_id", referencedcolumnname="id") } ) private set<category> categories; model (category.java): @id private string id; jpa when introduce following code, fails error above (i think problem new piece of code): join<t, category> category = from.join("id"); predicates.add(criteriabuilder.like(category....
Read more