c - Pebble crashes on `realloc`, but only in a certain function -


i'm using custom vector in pebble app. pebble crashing on call realloc.

main.c

#include <pebble.h> #include "movement.h"  static pointarray point_array;  int main(void) {;     point_array_create(&point_array, 1);     gpoint point1 = (gpoint){.x = 1, .y = 1};     gpoint point2 = (gpoint){.x = 2, .y = 2};     gpoint point3 = (gpoint){.x = 3, .y = 3};      point_array_push(&point_array, point1);     point_array_push(&point_array, point2);     point_array_push(&point_array, point3);     app_log(app_log_level_debug, "done\n"); }

movement.c

#include "movement.h" #include "pebble.h"   static void point_array_resize(pointarray *point_array){   point_array->capacity *= 2;   size_t new_size = point_array->capacity * sizeof(gpoint) + sizeof(gpoint);   point_array->points = (gpoint*)realloc(point_array->points, new_size); }   void point_array_create(pointarray *arr, int capacity) {     arr->points = (gpoint*)malloc(capacity * sizeof(gpoint));     arr->length = 0;     arr->capacity = capacity; }  void point_array_push(pointarray *point_array, gpoint point) {    app_log(app_log_level_debug, "pushing");    if (point_array->length > point_array->capacity) {     app_log(app_log_level_debug, "resizing");     point_array_resize(point_array);     app_log(app_log_level_debug, "successful resize");   }   point_array->points[point_array->length] = point;   point_array->length++;   app_log(app_log_level_debug, "+ length"); }

movement.h

#include <pebble.h> #include <stdlib.h> #include <math.h>  typedef struct {   gpoint *points;   int length;   int capacity; } pointarray;  void point_array_create(pointarray *arr, int capacity);  void point_array_push(pointarray *point_array, gpoint point);  void point_array_destroy(pointarray *point_array, gpoint point);  gpoint move(gpoint point, float distance, float degrees);

the logs show app crashing @ call realloc:

[debug] movement.c:20: pushing [debug] movement.c:29: + length [debug] movement.c:20: pushing [debug] movement.c:29: + length [debug] movement.c:20: pushing [debug] movement.c:23: resizing

here's tried:

  • the code runs fine on both gcc , clang (!).
  • i verified point_array , point_array->points not null and
  • new_size larger existing size of point_array->points.
  • i looked @ this issue, doesn't seem apply.
  • i tried calling realloc @ bottom of point_array_create, , works fine. doesn't work in point_array_resize.

in point_array_push, test if need resize points @ top, test wrong. resize if length has exceeded capacity, means have overrun array.

instead, check see if length has reached capacity.

  if (point_array->length == point_array->capacity) {     app_log(app_log_level_debug, "resizing");     point_array_resize(point_array);     app_log(app_log_level_debug, "successful resize");   }

Comments

Post a Comment

Popular posts from this blog

jOOQ update returning clause with Oracle -

according http://www.jooq.org/doc/3.8/manual/sql-building/sql-statements/update-statement/ jooq doesn't support returning clause in update statements databases except firebird , postgres. does know, still correct oracle jooq? according oracle's documentation, oracle db supports returning clase delete, insert, or update statements. incorrect manual you're right - manual wrong , should fixed: https://github.com/jooq/jooq/issues/5470 single row update returning jooq 3.8 added support single row update .. returning statements. internally, uses callablestatement , pl/sql block of form: begin update "my_table" set "my_table"."column" = 'xyz' "my_table"."id" = 1 returning "my_table"."id", "my_table"."column" ?, ?; ? := sql%rowcount; end; the relevant issue is: https://github.com/jooq/jooq/issues/5190 multi row update returning a...
Read more

java - Warning equals/hashCode on @Data annotation lombok with inheritance -

i have entity inherits other. on other hand, i'm using lombok project reduce boilerplate code, put @data annotation. annotation @data inheritance produces next warning: generating equals/hashcode implementation without call superclass, though class not extend java.lang.object. if intentional, add '@equalsandhashcode(callsuper=false)' type. is advisable add annotation @equalsandhashcode (callsuper = true) or @equalsandhashcode (callsuper = false) ? if not added, 1 callsuper=false or callsuper=true ? the default value false . 1 if don't specify , ignore warning. yes, recommended add @equalsandhashcode annotation on @data annotated classes extend else object. cannot tell if need true or false , depends on class hierarchy, , need examined on case-by-case basis. however, project or package, can configure in lombok.config call super methods if not direct subclass of object. lombok.equalsandhashcode.callsuper = call for configuration system ...
Read more

java - BasicPathUsageException: Cannot join to attribute of basic type -

i using java 8 jpa (hibernate 5.2.1). have clause works perfectly, until introduce clause make use foreign key table values too. i getting following error: basicpathusageexception: cannot join attribute of basic type i think problem related fact have join table, , not sure how create join using join table. employee - employee_category - category model (employee.java): @manytomany(cascade = cascadetype.all, fetch=fetchtype.eager) @jointable ( name="employee_category", joincolumns={ @joincolumn(name="emp_id", referencedcolumnname="id") }, inversejoincolumns={ @joincolumn(name="cat_id", referencedcolumnname="id") } ) private set<category> categories; model (category.java): @id private string id; jpa when introduce following code, fails error above (i think problem new piece of code): join<t, category> category = from.join("id"); predicates.add(criteriabuilder.like(category....
Read more